Resolve & jextract subcommands and further dis-entangle commands #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-make-resolve-command
branch
18 times, most recently
from
ceba384 to
5f33a61
Compare
ktoso
changed the title
ktoso
force-pushed
the
wip-make-resolve-command
branch
from
ad6bfc5 to
c0b2b44
Compare
We have to keep a vendored lib _for now_ because we need to support 6.0 and upstream library has dropped that. We may eventually do so as well, but currently we cannot require 6.1 yet.
phrased apache 2 license header; ignore it for now, it is compatible but we'll want to move to the package instead anyway shortly
This is primarily to ease up development envs and bring consistency / use the latest release etc.
This is important for swiftpm build plugins and the plugin will fail if we don't emit those empty files
ktoso
force-pushed
the
wip-make-resolve-command
branch
from
226e1c2 to
8fcd453
Compare
ktoso
force-pushed
the
wip-make-resolve-command
branch
from
8fcd453 to
d44b762
Compare
ktoso
changed the title
|
In order to land this big refactor, squashed this all into one commit; and will be doing smaller followups from here onwards. Any review comments please do leave if you have any and we'll follow up in separate PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big refactor; but completes our moves to subcommands and dis-entangles all the commands from eachother.
This also:
❗ When developing, please make sure that your JAVA_HOME uses e.g. JDK21, but you have 24 installed. This way gradle will build using 21 for running "itself" but will use the JDK 24 for the actual code.
resolves #261
resolves #260